refactor(relay): introduce Handler::new functions
#3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
thomaseizinger
changed the base branch from
master
to
no-run-title-as-command
mxinden
approved these changes
Jan 16, 2023
|
@mxinden This was a stacked PR and only meant to be merged once #3318 is merged. (Same as with many of my other ones that are currently open.) I stacked them to show that CI is completely green. Sorry for not calling this out explicitly. Should we disable mergify for non-master base PR to prevent this from happening in the future? |
thomaseizinger
added a commit
that referenced
this pull request
Jan 17, 2023
This reverts commit aed5363.
4 tasks
|
|
|
Oh, my bad. Does CI also run on drafts? If so, how about keeping them in draft state? |
That is what I did on all the other stacked PRs now, yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes
Will reduce the diff in #3254.
Links to any relevant issues
Open Questions
Change checklist