Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(relay): introduce Handler::new functions #3334

Merged
merged 7 commits into from
Jan 18, 2023
Merged

refactor(relay): introduce Handler::new functions #3334

merged 7 commits into from
Jan 18, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 17, 2023 •
edited
Loading

Description

Notes

Will reduce the diff in #3254.
Draft until #3318 is merged.
2nd attempt of #3326.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mergify mergify bot mentioned this pull request Jan 17, 2023
Merged
4 tasks
@thomaseizinger
Copy link
Contributor Author

This is ready for review despite being draft. Only #3318 needs to merge first.

@thomaseizinger thomaseizinger mentioned this pull request Jan 17, 2023
Merged
4 tasks
jxs
jxs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from no-run-title-as-command to master January 17, 2023 22:13
@thomaseizinger thomaseizinger marked this pull request as ready for review January 17, 2023 22:44
@thomaseizinger
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023

refresh

✅ Pull request refreshed

@thomaseizinger
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8cd14e6

@mergify mergify bot merged commit 8cd14e6 into master Jan 18, 2023
@mergify mergify bot deleted the 2824-handler-new-fns branch January 18, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @jxs