Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core)!: remove EitherFuture2 #3340

Merged
merged 24 commits into from
Jan 18, 2023
Merged

refactor(core)!: remove EitherFuture2 #3340

merged 24 commits into from
Jan 18, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

We can completely replace EitherFuture2 with EitherFuture. EitherFuture itself cannot be removed for now because the Future implementation on future::Either forces both Futures to evaluate to the same type.

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger
Use single quotes to avoid running commands
3a84c14
@thomaseizinger
Use intermediary variable
458aa53
@thomaseizinger
Merge branch 'master' into no-run-title-as-command
341d096
@thomaseizinger
refactor(relay): introduce Handler::new functions (#3326)
aed5363
@thomaseizinger
fix: revert "refactor(relay): introduce Handler::new functions" (#3333
5e97d0e 
)
@thomaseizinger
Replace EitherError with Either
da97e8f
@thomaseizinger
Add changelog entry
2ce805d
@thomaseizinger
Remove EitherTransport in favor of Either
0a2729d
@thomaseizinger
Update core/CHANGELOG.md
3397266
@thomaseizinger
Merge branch '2650-remove-either-error' into 2650-remove-either-trans…
5802177 
…port
@thomaseizinger
Add changelog entry
7060f4b
@thomaseizinger
Merge branch 'no-run-title-as-command' into 2650-remove-either-error
82eb6c2
@thomaseizinger
Merge branch 'master' into no-run-title-as-command
955ff80
@thomaseizinger
Merge branch 'no-run-title-as-command' into 2650-remove-either-error
bb84906
@thomaseizinger
Merge branch '2650-remove-either-error' into 2650-remove-either-trans…
fdfaf72 
…port
@thomaseizinger
Update changelog entry
59f6465
@thomaseizinger
Remove EitherUpgrade
8872039
@thomaseizinger
Update core/CHANGELOG.md
d3e79cf
@thomaseizinger
Remove EitherFuture2
1526051
@thomaseizinger
add changelog entry
1b25ec1
@thomaseizinger
Merge branch '2650-remove-either-upgrade' into 2650-remove-either-fut…
4164aa8 
…ure2
thomaseizinger
thomaseizinger commented Jan 17, 2023
View reviewed changes
core/CHANGELOG.md Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger commented Jan 17, 2023
View reviewed changes
core/CHANGELOG.md Outdated Show resolved Hide resolved
jxs
jxs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this Thomas!

Base automatically changed from 2650-remove-either-upgrade to master January 18, 2023 02:35
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2023

This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏

@mergify mergify bot merged commit 73cbbe2 into master Jan 18, 2023
@mergify mergify bot deleted the 2650-remove-either-future2 branch January 18, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @jxs