[DO NOT MERGE] v050 testplan backport #3439
Conversation
|
@thomaseizinger Can you take a look? If this looks good we should port the relevant changes to the master branch. |
| WORKDIR /workspace | ||
| ADD . . | ||
| RUN --mount=type=cache,target=./target \ | ||
| --mount=type=cache,target=/usr/local/cargo/registry \ |
There was a problem hiding this comment.
What exactly is the cache referenced here? Old layers that don't match exactly?
There was a problem hiding this comment.
This is a fairly new cool feature. It is a cache that is saved separate from layers. So even if the earlier layers get rebuilt we still persist our cargo and build cache. So builds will be just be fast without any tricks. https://docs.docker.com/engine/reference/builder/#run---mount
There was a problem hiding this comment.
This is amazing! Thank for your introducing me to this feature, that is indeed a godsend for Rust-based containers!
| @@ -0,0 +1,20 @@ | |||
| # syntax=docker/dockerfile:1.5-labs | |||
| FROM rust:1.67.0 | |||
There was a problem hiding this comment.
Can this be a multi-stage dockerfile?
There was a problem hiding this comment.
Sure, but why? We aren't pushing this to a registry or uploading/downloading the image somewhere.
There was a problem hiding this comment.
Right and we need to pull all layers anyway so I guess it doesn't matter!
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Sounds good |
Description
Updates the test implementation to follow the new spec.
Updates the dockerfile so it can be built by anyone, not just linux folks
In draft to fiddle with CI.