feat(interop-tests): build test binary inside container #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
commented
Feb 9, 2023
thomaseizinger
approved these changes
Feb 9, 2023
thomaseizinger
changed the title
|
@Mergifyio backport rust-v050-testplan rust-v049-testplan rust-v048-testplan |
❌ No backport have been created
|
Minor correction here, mergify will do it (hopefully) |
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
Building inside the container allows Windows and MacOS users to also build this binary. Thanks to a new feature from docker, `--mount=type=cache`, rebuilding layers is fast without any additional hacks. (cherry picked from commit eeca244) # Conflicts: # .dockerignore
|
@Mergifyio backport rust-v0490-testplan |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
Building inside the container allows Windows and MacOS users to also build this binary. Thanks to a new feature from docker, `--mount=type=cache`, rebuilding layers is fast without any additional hacks. (cherry picked from commit eeca244) # Conflicts: # .dockerignore # Cargo.toml
|
@Mergifyio backport rust-v0480-testplan |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
Building inside the container allows Windows and MacOS users to also build this binary. Thanks to a new feature from docker, `--mount=type=cache`, rebuilding layers is fast without any additional hacks. (cherry picked from commit eeca244) # Conflicts: # .dockerignore # Cargo.toml
thomaseizinger
pushed a commit
that referenced
this pull request
Feb 10, 2023
…) (#3442) Co-authored-by: Marco Munizaga <git@marcopolo.io>
thomaseizinger
pushed a commit
that referenced
this pull request
Feb 10, 2023
…) (#3444) Co-authored-by: Marco Munizaga <git@marcopolo.io>
thomaseizinger
pushed a commit
that referenced
this pull request
Feb 10, 2023
…) (#3443) Co-authored-by: Marco Munizaga <git@marcopolo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building inside the container allows Windows and MacOS users to also build this binary. Thanks to a new feature from docker,
--mount=type=cache, rebuilding layers is fast without any additional hacks.Notes
continuation of #3439 for master. @thomaseizinger will backport these tests to older versions once we merge this.