Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interop-tests): build test binary inside container (backport #3441) #3442

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 10, 2023

This is an automatic backport of pull request #3441 done by Mergify.
Cherry-pick of eeca244 has failed:

On branch mergify/bp/rust-v050-testplan/pr-3441
Your branch is up to date with 'origin/rust-v050-testplan'.

You are currently cherry-picking commit eeca244c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/interop-test.yml
	modified:   interop-tests/Dockerfile
	modified:   interop-tests/README.md
	modified:   interop-tests/src/bin/ping.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .dockerignore

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Building inside the container allows Windows and MacOS users to also build this binary. Thanks to a new feature from docker, `--mount=type=cache`, rebuilding layers is fast without any additional hacks.

(cherry picked from commit eeca244)

# Conflicts:
#	.dockerignore
@mergify mergify bot added the conflicts label Feb 10, 2023
@thomaseizinger thomaseizinger merged commit e60f0d4 into rust-v050-testplan Feb 10, 2023
@thomaseizinger thomaseizinger deleted the mergify/bp/rust-v050-testplan/pr-3441 branch February 10, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants