feat(kad): remove deprecated public modules #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
approved these changes
May 9, 2023
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Jun 6, 2023
Deprecated in libp2p#3738 Deprecation released with `v0.51.3`. Follow up to libp2p#3896 Part of libp2p#3647
4 tasks
gurinderu
reviewed
Jul 3, 2023
| mod jobs; | ||
| mod kbucket; |
There was a problem hiding this comment.
Why is it not public ?
take a look into get_closest_local_peers signature, it has a kbucket::Key as a parameter
There was a problem hiding this comment.
and the same story for handler + ConnectionClosed event
There was a problem hiding this comment.
Key is publicly exposed as KBucketKey. Does that solve your issue? The handler is an implementation detail. If you need to name it, you can use <Kademlia as NetworkBehaviour>::ConnectionHandler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch removes the 3 out of 4 deprecated public modules. I've left
storefor now because we made some mistakes in declaring that. The items withinstorestill need to be publicly visible but I haven't yet figured out a good way of exporting / naming them. Thus, I've left that to a follow-up PR.Related: #3647.
Notes & open questions
Change checklist