chore(kad): remove deprecated module record
#4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated in libp2p#3738 Deprecation released with `v0.51.3`. Follow up to libp2p#3896 Part of libp2p#3647
|
@tcoratger an @thomaseizinger can you take a look here? |
Yeah, at the time we left this one because it is not obvious how to expose the record store etc so everything has nice names. I'd be okay to leave this one for later, perhaps open a dedicated issue about it. |
|
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
thomaseizinger
approved these changes
Oct 20, 2023
|
@mxinden Still some Ci failures. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecated in #3738.
Follow up to #3896.
Part of #3647.
Notes & open questions
Change checklist