Instantiate the RemoteClusterWatcher with gatewayAlive=true (#8590) #8725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateiidavid
approved these changes
Jun 22, 2022
| @@ -204,6 +204,8 @@ func restartClusterWatcher( | |||
| repairPeriod, | |||
| probeWorker.Liveness, | |||
| enableHeadlessSvc, | |||
| // always instantiate the gatewayAlive=0 to prevent unexpected service fail fast | |||
There was a problem hiding this comment.
nit: would it make more sense for gatewayAlive=1 here? generally true evaluates to the constant 1, and false to 0.
There was a problem hiding this comment.
Sorry for the mistake, I'll correct this comment.
|
@mateiidavid I've publish this change to our cluster, but there's no watch restart yet. I'll give you the confirmation in maybe 12 hours. |
kleimkuhler
reviewed
Jun 22, 2022
If we don't instantiate the RemoteClusterWatcher with gatewayAlive=true, then there will be a small period all services will fail-fast unexpectedly. Simply Instantiate the RemoteClusterWatcher with gatewayAlive=true. Fix #8590 Signed-off-by: Ao Chen <chenao3220@gmail.com>
|
@mateiidavid Confirmed, the watch restarting happens and there's no service fail fast. It fixes my problem. |
kleimkuhler
approved these changes
Jun 23, 2022
kleimkuhler
pushed a commit
that referenced
this pull request
Jun 30, 2022
If we don't instantiate the RemoteClusterWatcher with gatewayAlive=true, then there will be a small period all services will fail-fast unexpectedly. Simply Instantiate the RemoteClusterWatcher with gatewayAlive=true. Fix #8590 Signed-off-by: Ao Chen <chenao3220@gmail.com>
kleimkuhler
added a commit
that referenced
this pull request
Jul 1, 2022
If we don't instantiate the RemoteClusterWatcher with gatewayAlive=true, then there will be a small period all services will fail-fast unexpectedly. Simply Instantiate the RemoteClusterWatcher with gatewayAlive=true. Signed-off-by: Ao Chen <chenao3220@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't instantiate the RemoteClusterWatcher
with gatewayAlive=true, then there will be a small
period all services will fail fast unexpectedly.
Simply Instantiate the RemoteClusterWatcher with
gatewayAlive=true.
Fix #8590
Signed-off-by: Ao Chen chenao3220@gmail.com