Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable-2.11.3: Cherry pick 8590 #8787

Merged
merged 1 commit into from
Jul 1, 2022
Merged

stable-2.11.3: Cherry pick 8590 #8787

merged 1 commit into from
Jul 1, 2022

Conversation

kleimkuhler
Copy link
Contributor

@kleimkuhler kleimkuhler commented Jun 30, 2022 •
edited
Loading

#8590

Part of #8779

@chenaoxd @kleimkuhler
Instantiate the rcsw with gatewayAlive=true (#8590) (#8725)
197f776 
If we don't instantiate the RemoteClusterWatcher
with gatewayAlive=true, then there will be a small
period all services will fail-fast unexpectedly.

Simply Instantiate the RemoteClusterWatcher with
gatewayAlive=true.

Fix #8590

Signed-off-by: Ao Chen <chenao3220@gmail.com>
@kleimkuhler kleimkuhler requested a review from a team as a code owner June 30, 2022 21:36
alpeb
alpeb approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kleimkuhler kleimkuhler merged commit a761f4f into release/stable-2.11 Jul 1, 2022
@kleimkuhler kleimkuhler deleted the kleimkuhler/cherry-pick-8590 branch July 1, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpeb alpeb alpeb approved these changes

@mateiidavid mateiidavid mateiidavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kleimkuhler @alpeb @mateiidavid @chenaoxd