popupMenu.js: Simplify the menu animation #12405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the menu animates a distance of 1/10 the menus height/width. This leads to some menus having a bit different animation then others. Switch to using a hard coded distance instead. With the smaller distance we can also now remove the set_clip() that is being used. That hurts performance, especially on HiDpi. That was being updated on every update of the tween. It also clips out any box shadow that the theme is using on the menu as a side effect. With the smaller amount of translation happening in the menu, slow down the speed of the animation just a bit. This results in the overall animation looking very similar to how it did before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the menu animates a distance of 1/10 the menus height/width. This leads to some menus having a bit different animation then others. Switch to using a hard coded distance instead. With the smaller distance we can also now remove the set_clip() that is being used. That hurts performance, especially on HiDpi. That was being updated on every update of the tween. It also clips out any box shadow that the theme is using on the menu as a side effect.
With the smaller amount of translation happening in the menu, slow down the speed of the animation just a bit. This results in the overall animation looking very similar to how it did before.