Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popupMenu.js: Simplify the menu animation #12405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

popupMenu.js: Simplify the menu animation #12405

wants to merge 1 commit into from

Commits on Sep 22, 2024

  1. popupMenu.js: Simplify the menu animation 

    Currently the menu animates a distance of 1/10 the menus height/width. This
leads to some menus having a bit different animation then others. Switch to
using a hard coded distance instead. With the smaller distance we can also
now remove the set_clip() that is being used. That hurts performance,
especially on HiDpi. That was being updated on every update of the tween.
It also clips out any box shadow that the theme is using on the menu as a
side effect.

With the smaller amount of translation happening in the menu, slow down the
speed of the animation just a bit. This results in the overall animation
looking very similar to how it did before.
    @JosephMcc
    JosephMcc committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fdc6c5d View commit details
    Browse the repository at this point in the history