Convert the force quit dialog to a cinnamon dialog #12408
+228
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this for the force-close dialog. It will be included in the MetaWindowGroup, but needs to tracked as chrome to recieve pointer events
With the new dialogs and theming in place we can start looking at converting some of these away from Gtk dialogs
Gtk dialogs have the action on the right so move the Force Quit button to the right side to match the layout users are accustomed to
|
Hello @JosephMcc, does this PR fix the issue below as well?
That text in the list view was not getting the proper text theme according to the dark theme (which should be white I suppose), also I'm not sure if the translation is implemented for that (if it is possible). |
|
Yes. It would no longer be a GTK dialog so that but would no longer be relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.