Skip to content

Commit

Permalink
Updated probe timeout and removed response timeout from httpProbe (#3796
Browse files Browse the repository at this point in the history
)

Signed-off-by: Amit Kumar Das <amit.das@harness.io>

Signed-off-by: Amit Kumar Das <amit.das@harness.io>
  • Loading branch information
amityt committed Oct 19, 2022
1 parent 88719e9 commit b72b2a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ const ProbeDetails: React.FC<ProbeDetailsProps> = ({
},
});
}
if (e.target.name === 'responseTimeout') {
setProbeData({
...probeData,
'httpProbe/inputs': {
...probeData['httpProbe/inputs'],
[e.target.name]: parseInt(e.target.value as string, 10),
},
});
}
if (e.target.name === 'insecureSkipVerify') {
setProbeData({
...probeData,
Expand Down Expand Up @@ -197,23 +188,6 @@ const ProbeDetails: React.FC<ProbeDetailsProps> = ({
<MenuItem value="false">False</MenuItem>
</Select>
</div>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="responseTimeout">
{t(
'createWorkflow.tuneWorkflow.addProbe.inputLabels.responseTimeout'
)}
(ms)
</InputLabel>
<InputField
variant="primary"
width="50%"
id="responseTimeout"
name="responseTimeout"
type="number"
value={probeData['httpProbe/inputs']?.responseTimeout}
onChange={handleHttp}
/>
</div>
<div className={classes.inputSub}>
{t('createWorkflow.tuneWorkflow.addProbe.inputLabels.request')}
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,8 @@ const AddProbe: React.FC<AddProbeProps> = ({
<div className={classes.detailContainer}>
<div className={classes.formField}>
<InputLabel className={classes.formLabel} htmlFor="timeout">
{t('createWorkflow.tuneWorkflow.addProbe.labels.timeout')}(sec)
{t('createWorkflow.tuneWorkflow.addProbe.labels.timeout')}{' '}
{probeData.type === 'httpProbe' ? `(ms)` : `(sec)`}
<span className={classes.required}>*</span>
</InputLabel>
<InputField
Expand Down

0 comments on commit b72b2a9

Please sign in to comment.