Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated probe timeout unit and removed response timeout from httpProbe #3796

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

amityt
Copy link
Contributor

@amityt amityt commented Oct 19, 2022

Signed-off-by: Amit Kumar Das amit.das@harness.io

Proposed changes

This PR adds:

  • Timeout unit to be ms only for httpProbe
  • Removed responseTimeout from httpProbe

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Screenshot 2022-10-19 at 1 52 54 PM
Screenshot 2022-10-19 at 1 53 06 PM

Signed-off-by: Amit Kumar Das <amit.das@harness.io>
@probot-auto-merge probot-auto-merge bot merged commit b72b2a9 into litmuschaos:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants