Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flang][OpenMP] Add a proper test for orphaned section directive #93342

Open
kiranchandramohan opened this issue May 24, 2024 · 2 comments
Open

[Flang][OpenMP] Add a proper test for orphaned section directive #93342

kiranchandramohan opened this issue May 24, 2024 · 2 comments
Labels
flang:frontend flang:openmp test-suite

Comments

@kiranchandramohan
Copy link
Contributor

kiranchandramohan commented May 24, 2024 •
edited
Loading

Section directive should appear in the sections construct. It cannot appear as orphaned directives. This is currently caught in parsing but there is no graceful error.

program OmpOrphanedSections
   use omp_lib
   integer counter
   counter = 0
   !$omp section
   print *, "An orphaned section containing a single statement"
   !$omp section
   counter = counter + 1
   print *, "An orphaned section containing multiple statements"
!$omp sections
   !$omp section
   print *, "Not an orphan structured block"
!$omp end sections
@github-actions github-actions bot added the flang Flang issues not falling into any other category label May 24, 2024
@kiranchandramohan kiranchandramohan mentioned this issue May 24, 2024
Merged
kiranchandramohan added a commit that referenced this issue May 24, 2024
@kiranchandramohan
[Flang][OpenMP] Remove the orphan section test (#93343)
57be0d2 
Remove this test since it is marked as XFAIL and has some
non-deterministic behaviour which causes it to spuriously pass on
out-of-tree builds.

Capturing this in #93342 to
make a proper fix and a test later.
@EugeneZelenko EugeneZelenko added test-suite clang:frontend Language frontend issues, e.g. anything involving "Sema" and removed flang Flang issues not falling into any other category labels May 25, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 25, 2024

@llvm/issue-subscribers-clang-frontend

Author: Kiran Chandramohan (kiranchandramohan)

Section directive should appear in the sections construct. It cannot appear as orphaned directives. This is currently caught in parsing but there is no graceful error. 
program OmpOrphanedSections
   use omp_lib
   integer counter
   counter = 0
   !$omp section
   print *, "An orphaned section containing a single statement"
   !$omp section
   counter = counter + 1
   print *, "An orphaned section containing multiple statements"
!$omp sections
   !$omp section
   print *, "Not an orphan structured block"
!$omp end sections

@EugeneZelenko EugeneZelenko added flang:frontend and removed clang:frontend Language frontend issues, e.g. anything involving "Sema" labels May 25, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 25, 2024

@llvm/issue-subscribers-flang-frontend

Author: Kiran Chandramohan (kiranchandramohan)

Section directive should appear in the sections construct. It cannot appear as orphaned directives. This is currently caught in parsing but there is no graceful error. 
program OmpOrphanedSections
   use omp_lib
   integer counter
   counter = 0
   !$omp section
   print *, "An orphaned section containing a single statement"
   !$omp section
   counter = counter + 1
   print *, "An orphaned section containing multiple statements"
!$omp sections
   !$omp section
   print *, "Not an orphan structured block"
!$omp end sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flang:frontend flang:openmp test-suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kiranchandramohan @EugeneZelenko @llvmbot