Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flang][OpenMP] Remove the orphan section test #93343

Merged
merged 1 commit into from
May 24, 2024

Conversation

kiranchandramohan
Copy link
Contributor

Remove this test since it is marked as XFAIL and has some non-deterministic behaviour which causes it to spuriously pass on out-of-tree builds.

Capturing this in #93342 to make a proper fix and a test later.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:openmp flang:semantics labels May 24, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 24, 2024

@llvm/pr-subscribers-flang-semantics

@llvm/pr-subscribers-flang-openmp

Author: Kiran Chandramohan (kiranchandramohan)

Changes

Remove this test since it is marked as XFAIL and has some non-deterministic behaviour which causes it to spuriously pass on out-of-tree builds.

Capturing this in #93342 to make a proper fix and a test later.


Full diff: https://github.com/llvm/llvm-project/pull/93343.diff

1 Files Affected:

  • (removed) flang/test/Semantics/OpenMP/sections03.f90 (-27)
diff --git a/flang/test/Semantics/OpenMP/sections03.f90 b/flang/test/Semantics/OpenMP/sections03.f90
deleted file mode 100644
index eb7e83ae2fd87..0000000000000
--- a/flang/test/Semantics/OpenMP/sections03.f90
+++ /dev/null
@@ -1,27 +0,0 @@
-! RUN: %python %S/../test_errors.py %s %flang_fc1 %openmp_flags
-!XFAIL: *
-! OpenMP version 5.0.0
-! 2.8.1 sections construct
-! Orphaned section directives are prohibited. That is, the section directives must appear within the sections construct and must not be encountered elsewhere in the sections region
-!TODO: Error in parsing. Make parser errors more informative. Until then, the test is XFAIL
-
-program OmpOrphanedSections
-   use omp_lib
-   integer counter
-   counter = 0
-   !CHECK: expected 'END'
-   !CHECK: END PROGRAM statement
-   !CHECK: in the context: main program
-   !CHECK: expected 'END PROGRAM'
-   !CHECK: in the context: END PROGRAM statement
-   !CHECK: in the context: main program
-   !$omp section
-   print *, "An orphaned section containing a single statement"
-   !$omp section
-   counter = counter + 1
-   print *, "An orphaned section containing multiple statements"
-!$omp sections
-   !$omp section
-   print *, "Not an orphan structured block"
-!$omp end sections
-end program OmpOrphanedSections

Copy link
Contributor

@clementval clementval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kiran

@kiranchandramohan kiranchandramohan merged commit 57be0d2 into llvm:main May 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:openmp flang:semantics flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants