Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity: fix new dlevel check fails #127

Merged
merged 7 commits into from
Nov 5, 2022
Merged

sanity: fix new dlevel check fails #127

merged 7 commits into from
Nov 5, 2022

Conversation

lowlydba
Copy link
Owner

@lowlydba lowlydba commented Nov 5, 2022

Description

Fix new sanity check error on dlevel - ansible-collections/news-for-maintainers#25 (comment)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - Fixes #
  • New feature (non-breaking change which adds functionality)

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Base: 94.05% // Head: 94.05% // No change to project coverage 👍

Coverage data is based on head (734432b) compared to base (940f635).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          59       59           
  Lines        2002     2002           
=======================================
  Hits         1883     1883           
  Misses        119      119           
Impacted Files Coverage Δ
plugins/modules/ag_replica.ps1 92.70% <100.00%> (ø)
plugins/modules/agent_job_schedule.ps1 98.11% <100.00%> (ø)
plugins/modules/agent_job_step.ps1 97.14% <100.00%> (ø)
plugins/modules/availability_group.ps1 93.75% <100.00%> (ø)
plugins/modules/install_script.ps1 96.42% <100.00%> (ø)
plugins/modules/maintenance_solution.ps1 94.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main

@lowlydba lowlydba changed the title sanity: fix maint_sol default to match docs sanity: fix new dlevel check fails Nov 5, 2022
briantist
briantist previously approved these changes Nov 5, 2022
changelogs/fragments/127-fix-doc-check.yml Outdated Show resolved Hide resolved
@lowlydba lowlydba merged commit efeb654 into main Nov 5, 2022
@lowlydba lowlydba deleted the fix-dlevel branch November 5, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants