sanity: fix new dlevel check fails

CHANGELOG.rst

@@ -5,6 +5,19 @@ lowlydba.sqlserver Release Notes
 .. contents:: Topics
 
 
+v1.0.4
+======
+
+Release Summary
+---------------
+
+Minor fixes to resolve new dlevel sanity checks.
+
+Bugfixes
+--------
+
+- Fix cleanup_time default to match documentation default & lint fixes (https://github.com/lowlydba/lowlydba.sqlserver/pull/127).
+
 v1.0.3
 ======
 

changelogs/changelog.yaml

@@ -306,3 +306,12 @@ releases:
     - 122-doc-fixes.yml
     - v1-0-3-release-summary.yml
     release_date: '2022-09-03'
+  1.0.4:
+    changes:
+      bugfixes:
+      - Fix cleanup_time default to match documentation default & lint fixes (https://github.com/lowlydba/lowlydba.sqlserver/pull/127).
+      release_summary: Minor fixes to resolve new dlevel sanity checks.
+    fragments:
+    - 127-fix-doc-check.yml
+    - release-summary.yml
+    release_date: '2022-11-05'

galaxy.yml

@@ -2,7 +2,7 @@
 
 namespace: lowlydba
 name: sqlserver
-version: 1.0.3
+version: 1.0.4
 readme: README.md
 authors:
   - John McCall (github.com/lowlydba)

plugins/modules/ag_replica.ps1

@@ -21,46 +21,46 @@ $spec = @{
         endpoint_url = @{type = 'str'; required = $false }
         backup_priority = @{type = 'int'; required = $false; default = 50 }
         failover_mode = @{
-            type = 'str';
-            required = $false;
-            default = 'Manual';
+            type = 'str'
+            required = $false
+            default = 'Manual'
             choices = @('Manual', 'Automatic')
         }
         availability_mode = @{
-            type = 'str';
-            required = $false; default = 'AsynchronousCommit';
+            type = 'str'
+            required = $false; default = 'AsynchronousCommit'
             choices = @('SynchronousCommit', 'AsynchronousCommit')
         }
         seeding_mode = @{
-            type = 'str';
-            required = $false;
-            default = 'Automatic';
+            type = 'str'
+            required = $false
+            default = 'Automatic'
             choices = @('Manual', 'Automatic')
         }
         connection_mode_in_primary_role = @{
-            type = 'str';
-            required = $false;
-            default = 'AllowAllConnections';
+            type = 'str'
+            required = $false
+            default = 'AllowAllConnections'
             choices = @('AllowReadIntentConnectionsOnly', 'AllowAllConnections')
         }
         connection_mode_in_secondary_role = @{
-            type = 'str';
-            required = $false;
-            default = 'AllowNoConnections';
+            type = 'str'
+            required = $false
+            default = 'AllowNoConnections'
             choices = @('AllowNoConnections', 'AllowReadIntentConnectionsOnly', 'AllowAllConnections')
         }
         read_only_routing_connection_url = @{
-            type = 'str';
-            required = $false;
+            type = 'str'
+            required = $false
         }
         read_only_routing_list = @{
-            type = 'str';
-            required = $false;
+            type = 'str'
+            required = $false
         }
         cluster_type = @{
-            type = 'str';
-            required = $false;
-            default = 'Wsfc';
+            type = 'str'
+            required = $false
+            default = 'Wsfc'
             choices = @('Wsfc', 'External', 'None')
         }
         configure_xe_session = @{ type = 'bool'; required = $false; default = $false }

plugins/modules/agent_job_schedule.ps1

@@ -17,7 +17,7 @@ $spec = @{
         job = @{type = 'str'; required = $true }
         enabled = @{type = 'bool'; required = $false }
         force = @{type = 'bool'; required = $false }
-        frequency_type = @{type = 'str'; required = $false;
+        frequency_type = @{type = 'str'; required = $false
             choices = @('Once', 'OneTime', 'Daily', 'Weekly', 'Monthly', 'MonthlyRelative', 'AgentStart', 'AutoStart', 'IdleComputer', 'OnIdle')
         }
         frequency_interval = @{type = 'str'; required = $false; }

plugins/modules/agent_job_step.ps1

@@ -17,15 +17,15 @@ $spec = @{
         step_id = @{type = 'int'; required = $false }
         step_name = @{type = 'str'; required = $false }
         database = @{type = 'str'; required = $false; default = 'master' }
-        subsystem = @{type = 'str'; required = $false; default = 'TransactSql';
+        subsystem = @{type = 'str'; required = $false; default = 'TransactSql'
             choices = @('CmdExec', 'Distribution', 'LogReader', 'Merge', 'PowerShell', 'QueueReader', 'Snapshot', 'Ssis', 'TransactSql')
         }
         command = @{type = 'str'; required = $false }
-        on_success_action = @{type = 'str'; required = $false; default = 'QuitWithSuccess';
+        on_success_action = @{type = 'str'; required = $false; default = 'QuitWithSuccess'
             choices = @('QuitWithSuccess', 'QuitWithFailure', 'GoToNextStep', 'GoToStep')
         }
         on_success_step_id = @{type = 'int'; required = $false; default = 0 }
-        on_fail_action = @{type = 'str'; required = $false; default = 'QuitWithFailure';
+        on_fail_action = @{type = 'str'; required = $false; default = 'QuitWithFailure'
             choices = @('QuitWithSuccess', 'QuitWithFailure', 'GoToNextStep', 'GoToStep')
         }
         on_fail_step_id = @{type = 'int'; required = $false; default = 0 }

plugins/modules/availability_group.ps1

@@ -27,14 +27,14 @@ $spec = @{
         use_last_backup = @{type = "bool"; required = $false; }
         healthcheck_timeout = @{type = "int"; required = $false; }
         availability_mode = @{
-            type = "str";
-            required = $false;
+            type = "str"
+            required = $false
             default = "SynchronousCommit"
             choices = @("SynchronousCommit", "AsynchronousCommit")
         }
         failure_condition_level = @{
-            type = "str";
-            required = $false;
+            type = "str"
+            required = $false
             choices = @(
                 "OnAnyQualifiedFailureCondition",
                 "OnCriticalServerErrors",
@@ -44,27 +44,27 @@ $spec = @{
             )
         }
         failover_mode = @{
-            type = "str";
-            required = $false;
-            default = "Automatic";
+            type = "str"
+            required = $false
+            default = "Automatic"
             choices = @("Manual", "Automatic")
         }
         seeding_mode = @{
-            type = "str";
-            required = $false;
-            default = "Manual";
+            type = "str"
+            required = $false
+            default = "Manual"
             choices = @("Manual", "Automatic")
         }
         automated_backup_preference = @{
-            type = "str";
-            required = $false;
-            default = "Secondary";
+            type = "str"
+            required = $false
+            default = "Secondary"
             choices = @("None", "Primary", "Secondary", "SecondaryOnly")
         }
         cluster_type = @{
-            type = "str";
-            required = $false;
-            default = "Wsfc";
+            type = "str"
+            required = $false
+            default = "Wsfc"
             choices = @("Wsfc", "External", "None")
         }
         allow_null_backup = @{type = "bool"; required = $false }

plugins/modules/install_script.ps1

@@ -14,7 +14,7 @@ $spec = @{
     options = @{
         database = @{type = 'str'; required = $true }
         path = @{type = 'str'; required = $true }
-        deployment_method = @{type = 'str'; required = $false; default = 'NoTransaction';
+        deployment_method = @{type = 'str'; required = $false; default = 'NoTransaction'
             choices = @('NoTransaction', 'SingleTransaction', 'TransactionPerScript')
         }
         schema_version_table = @{type = 'str'; required = $false }

plugins/modules/maintenance_solution.ps1

@@ -14,7 +14,7 @@ $spec = @{
     supports_check_mode = $true
     options = @{
         backup_location = @{type = 'str'; required = $false }
-        cleanup_time = @{type = 'int'; required = $false; }
+        cleanup_time = @{type = 'int'; required = $false; default = 0 }
         output_file_dir = @{type = 'str'; required = $false }
         replace_existing = @{type = 'bool'; required = $false; }
         log_to_table = @{type = 'bool'; required = $false; default = $false }