Fix Configurable attribute options are not sorted #7441 #12420
Conversation
magento-engcom-team
added
bugfix
Component: Catalog
Reproduced on 2.1.x
|
Hi @larsroettig, there was a feedback #7441 (comment) such solution does not work in 2.2.x but hope you tried it in action :) |
| @@ -97,6 +101,8 @@ public function getSelect(AbstractAttribute $superAttribute, int $productId, Sco | |||
| )->where( | |||
| 'attribute.attribute_id = ?', | |||
| $superAttribute->getAttributeId() | |||
| )->order( | |||
| 'attribute_opt.sort_order ASC' | |||
There was a problem hiding this comment.
Changes looks good to me.
Please update existing unit test: https://travis-ci.org/magento/magento2/jobs/306413370 and add a separate test method to just check options are returned in correct order.
After that please do an amend commit and force push to the same branch.
There was a problem hiding this comment.
Yea I already see maybe I add also a integrations test because only PHPUnit test makes not so much sense.
There was a problem hiding this comment.
True, something involving a real database would be more than appreciated here.
|
Hi @larsroettig, did you meet any obstacles with this PR? |
|
Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened. |
See github issue magento#7441, internal ticket MAGETWO-61484 and PR magento#12420.
Bugfix for #7441 - Configurable attribute options are not sorted
Steps to reproduce
Create a configurable attribute and add two options at least.
Create a configurable product for these options.
Go to the product page and see the configurable attribute select (options).
Change attribute options sort order and flush all caches.
Go to the product page and see the configurable attribute select (options) looks like before.
Expected result:
Configurable options HAVE been reordered.
Contribution checklist