Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort configurable attribute options by sort_order #12963

Merged

Conversation

wardcapp
Copy link
Contributor

@wardcapp wardcapp commented Jan 2, 2018

See github issue #7441, internal ticket MAGETWO-61484 and PR #12420.

Description

Resolves the issue documented in GitHub ticket #7441. A similar PR was opened before (#12420), which is re-opened by this PR and required changes to the related unit tests were made as well.

Fixed Issues

  1. Configurable attribute options are not sorted #7441: Configurable attribute options are not sorted

Manual testing scenarios

(copied over from PR #12420, which is still valid)
Steps to reproduce
Create a configurable attribute and add two options at least.
Create a configurable product for these options.
Go to the product page and see the configurable attribute select (options).
Change attribute options sort order and flush all caches.
Go to the product page and see the configurable attribute select (options) looks like before.

Expected result:
Configurable options HAVE been reordered.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests
  • All automated tests passed successfully (was tested with success locally, awaiting results from Travis)

When fetching configurable options using the configurable product
option select builder, the sort_order of each option should be taken
into account as well, making sure the desired sorting is passed to the
frontend.

See github issue magento#7441, internal ticket MAGETWO-61484 and PR#12420 for more on this.
@magento-engcom-team magento-engcom-team added bugfix Component: Catalog Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 2, 2018
@ishakhsuvarov ishakhsuvarov self-assigned this Jan 3, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 3, 2018
@RakeshJesadiya
Copy link
Contributor

@wardcapp, Any solutions available till for Magento 2.2.2? I have same issue sort order of attribute options are not properly.

@magento-team magento-team merged commit 9794d38 into magento:2.2-develop Jan 5, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 5, 2018
@wardcapp
Copy link
Contributor Author

wardcapp commented Jan 5, 2018

Hi @RakeshJesadiya, if you don't want to wait for the next patch release to become public, applying the pull request on Magento 2.2.2 should work too (which I just tested, with success):
https://github.com/magento/magento2/pull/12963.patch
Using the Composer patch plugin the patch can be applied easily to the Magento installation (in case it was set up using composer).

@asadyar
Copy link

asadyar commented Oct 1, 2018

Experiencing the same issue in Magento 2.2.5, All solution mentioned above is not working for Magento 2.2.5, They suggested code changes are added in Magento 2.2.5 files but sort order is still not fixed.

Any news on this issue, is it fixed in Magento 2.2.6 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants