This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Initialize offline storage on main thread before snapshotting #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-snapshotter-main-227
branch
from
c6820bc
to
17ad571
Compare
| // https://github.com/mapbox/mapbox-gl-native-ios/issues/227 | ||
| if ([NSThread.currentThread isMainThread]) { | ||
| (void)[MGLOfflineStorage sharedOfflineStorage]; | ||
| } else { | ||
| [NSException raise:NSInvalidArgumentException | ||
| format:@"startWithQueue:completionHandler: must be called from a thread with an active run loop."]; |
There was a problem hiding this comment.
We should probably change this exception to something like "startWithQueue:completionHandler: must be called from main thread."
There was a problem hiding this comment.
Good catch. This reminds me that we have an MGLAssertIsMainThread() macro, but I think we do want to raise an exception explicitly (across all build configurations) instead of potentially only asserting in Debug.
nishant-karajgikar
approved these changes
Apr 7, 2020
1ec5
force-pushed
the
1ec5-snapshotter-main-227
branch
from
17ad571
to
9449b65
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that offline storage has been initialized on the main thread, as MGLMapView and MGLOfflineStorage do when used directly. This fixes a regression introduced in #210 as well as fixing some potential undefined behavior from previous releases if MGLMapSnapshotter had been used on a background thread before any direct MGLOfflineStorage or MGLMapView usage.
Fixes #227.
/cc @mapbox/maps-ios