Don't call initialize twice when getStyle callback fires several times. #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunikkk
commented
Feb 2, 2022
| @@ -49,20 +49,22 @@ internal class LocationPuckManager( | |||
| } | |||
|
|
|||
| fun initialize(style: StyleInterface) { | |||
There was a problem hiding this comment.
Initialize method called from updateSettings waits for the style at getStyle.
If updateSettings was called multiple times multiple callbacks will fire after style arrives causing crash.
pengdev
reviewed
Feb 2, 2022
...ponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 4, 2022
...ationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationPuckManager.kt
Show resolved
Hide resolved
kiryldz
reviewed
Feb 4, 2022
...nt/src/test/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImplTest.kt
Show resolved
Hide resolved
|
Missing update changelog and guess it would be nice to add a bit more details about the issue we're fixing here as current entry is very high-level |
yunikkk
force-pushed
the
yds-fix-location-layer-added-twice
branch
from
9486246
to
ce4b6f4
Compare
tobrun
approved these changes
Feb 4, 2022
Chaoba
approved these changes
Feb 7, 2022
kiryldz
approved these changes
Feb 7, 2022
kiryldz
reviewed
Feb 7, 2022
Co-authored-by: Kiryl Dzehtsiarenka <kiryl.dzehtsiarenka@mapbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes possible crash with Location persistent layer being added twice.
This had happened for 1tap, for example.
Summary of changes
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).mapbox-maps-androidchangelog:<changelog>Fix crash within location plugin that happens when style is reloaded simultaneously with location plugin updates.</changelog>.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.