Don't call initialize twice when getStyle callback fires several times.

CHANGELOG.md

@@ -9,6 +9,7 @@ Mapbox welcomes participation and contributions from everyone.
 
 ## Bug fixes 🐞
 * Fix skipping / crashing user events scheduled on a render thread with `MapView#queueEvent`. ([#1068](https://github.com/mapbox/mapbox-maps-android/pull/1068))
+* Fix crash within location plugin that happens when style is reloaded simultaneously with location plugin updates. ([#1112](https://github.com/mapbox/mapbox-maps-android/pull/1112))
 
 # 10.3.0 February 7, 2022
 

plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt

@@ -174,11 +174,7 @@ class LocationComponentPluginImpl : LocationComponentPlugin, LocationConsumer,
             )
           )
         }
-        locationPuckManager?.let {
-          if (!it.isLayerInitialised()) {
-            it.initialize(style)
-          }
-        }
+        locationPuckManager?.initialize(style)
         locationPuckManager?.onStart()
         locationProvider?.registerLocationConsumer(this)
         isLocationComponentActivated = true

plugin-locationcomponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationPuckManager.kt

@@ -49,20 +49,22 @@ internal class LocationPuckManager(
     }
 
   fun initialize(style: StyleInterface) {
-    animationManager.setUpdateListeners(onLocationUpdated, onBearingUpdated)
-    animationManager.setLocationLayerRenderer(locationLayerRenderer)
-    animationManager.applyPulsingAnimationSettings(settings)
-    locationLayerRenderer.addLayers(positionManager)
-    lastLocation?.let {
-      updateCurrentPosition(it)
-    }
-    updateCurrentBearing(lastBearing)
-    locationLayerRenderer.initializeComponents(style)
-    styleScaling(settings)
-    if (lastLocation != null && settings.enabled) {
-      show()
-    } else {
-      hide()
+    if (!locationLayerRenderer.isRendererInitialised()) {
+      animationManager.setUpdateListeners(onLocationUpdated, onBearingUpdated)
+      animationManager.setLocationLayerRenderer(locationLayerRenderer)
+      animationManager.applyPulsingAnimationSettings(settings)
+      locationLayerRenderer.addLayers(positionManager)
+      lastLocation?.let {
+        updateCurrentPosition(it)
+      }
+      updateCurrentBearing(lastBearing)
+      locationLayerRenderer.initializeComponents(style)
+      styleScaling(settings)
+      if (lastLocation != null && settings.enabled) {
+        show()
+      } else {
+        hide()
+      }
     }
   }
 

plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImplTest.kt

@@ -197,22 +197,6 @@ class LocationComponentPluginImplTest {
     assertEquals(mockLocationProvider, locationComponentPlugin.getLocationProvider())
   }
 
-  @Test
-  fun testOnStyleChanged() {
-    every { locationPuckManager.isLayerInitialised() } returns false
-    preparePluginInitialisationWithEnabled()
-    verify(exactly = 2) { locationPuckManager.isLayerInitialised() }
-    verify(exactly = 1) { locationPuckManager.initialize(style) }
-  }
-
-  @Test
-  fun testOnStyleChangedWhilePuckManagerInitialised() {
-    every { locationPuckManager.isLayerInitialised() } returns true
-    preparePluginInitialisationWithEnabled()
-    verify(exactly = 2) { locationPuckManager.isLayerInitialised() }
-    verify(exactly = 0) { locationPuckManager.initialize(style) }
-  }
-
   @Test
   fun testOnStart() {
     every { locationPuckManager.isLayerInitialised() } returns false

plugin-locationcomponent/src/test/java/com/mapbox/maps/plugin/locationcomponent/LocationPuckManagerTest.kt

@@ -260,6 +260,20 @@ class LocationPuckManagerTest {
     )
   }
 
+  @Test
+  fun testDoesntInitialiseIfRendererInitialised() {
+    every { locationLayerRenderer.isRendererInitialised() } returns true
+
+    locationPuckManager.initialize(style)
+
+    verify(exactly = 0) { animationManager.setLocationLayerRenderer(locationLayerRenderer) }
+    verify(exactly = 0) { animationManager.setUpdateListeners(any(), any()) }
+    verify(exactly = 0) { animationManager.applyPulsingAnimationSettings(settings) }
+    verify(exactly = 0) { locationLayerRenderer.addLayers(positionManager) }
+    verify(exactly = 0) { locationLayerRenderer.initializeComponents(style) }
+    verify(exactly = 0) { locationLayerRenderer.hide() }
+  }
+
   private companion object {
     const val MODEL_SCALE_CONSTANT = 2965820.800757861
   }