Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gradle-version, dependencies, support JDK 11 #1118

Merged
merged 9 commits into from
Feb 17, 2022
Merged

Bump gradle-version, dependencies, support JDK 11 #1118

merged 9 commits into from
Feb 17, 2022

Conversation

ank27
Copy link
Contributor

@ank27 ank27 commented Feb 4, 2022 •
edited
Loading

Summary of changes

Dependencies updated

  • Android gradle plugin to 7.0.4.
  • Gradle version to 7.0.2.
  • Gradle licence plugin to 0.8.80.
  • Jacoco to 0.8.7.
  • Kotlin gradle plugin to 1.5.31.

Since we adapt to Gradle plugin 7.0, JDK 11 is now required to run the project.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Update android gradle plugin to v7.0.4, gradle version to v7.0.2, Gradle licence plugin to 0.8.80, Kotlin gradle plugin to 1.5.31, Jacoco to 0.8.7</changelog>.
  • If this PR is a v10.4 release branch fix / enhancement, merge it to main firstly and then port to v10.4 release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@ank27 ank27 self-assigned this Feb 4, 2022
@ank27 ank27 force-pushed the ak-add-plugins-version branch 3 times, most recently from c1ce854 to 5b23f0d Compare February 4, 2022 14:25
@ank27 ank27 marked this pull request as ready for review February 7, 2022 09:32
@ank27 ank27 requested a review from a team as a code owner February 7, 2022 09:32
@ank27 ank27 requested a review from tarigo February 7, 2022 09:38
@ank27 ank27 added the dependencies Pull requests that update a dependency file label Feb 7, 2022
@ank27 ank27 force-pushed the ak-add-plugins-version branch 3 times, most recently from b291a5a to a931e89 Compare February 7, 2022 10:44
yunikkk
yunikkk reviewed Feb 7, 2022
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
@kiryldz
Copy link
Contributor

kiryldz commented Feb 7, 2022

@ank27 why should this be ported to stable v10.3? I'm judging based on a checkbox

@kiryldz
Copy link
Contributor

kiryldz commented Feb 7, 2022

Just pointing out that this PR will be split in 2:

did I get it correct @ank27 ?

@ank27 ank27 marked this pull request as draft February 7, 2022 13:38
@ank27
Copy link
Contributor Author

ank27 commented Feb 7, 2022

Just pointing out that this PR will be split in 2:

did I get it correct @ank27 ?

Yes, this pr is now related to gradle bump (for 10.4-beta.1), and versions plugin added to #1123.

@pengdev pengdev mentioned this pull request Feb 7, 2022
Merged
9 tasks
pengdev
pengdev reviewed Feb 9, 2022
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
pengdev
pengdev reviewed Feb 9, 2022
View reviewed changes
LICENSE.md Outdated Show resolved Hide resolved
@ank27 ank27 force-pushed the ak-add-plugins-version branch 5 times, most recently from 70bb961 to ece1a9f Compare February 11, 2022 16:36
@ank27 ank27 marked this pull request as ready for review February 15, 2022 13:48
@pengdev pengdev mentioned this pull request Feb 15, 2022
Closed
8 tasks
@kiryldz
Copy link
Contributor

kiryldz commented Feb 15, 2022

@ank27 is it expected that we did pull so many new libraries (based on license file)? I remember we once did pull similar amount of libraries because common introduced dependency on play-services which increased our binary size a lot.

@ank27
Copy link
Contributor Author

ank27 commented Feb 15, 2022

@ank27 is it expected that we did pull so many new libraries (based on license file)? I remember we once did pull similar amount of libraries because common introduced dependency on play-services which increased our binary size a lot.

Good point, though I think these are added because we bumped the license plugin to v0.8.90 mentioned here too and common hasn't added any extra dependencies (just updated the current versions), I will check the size of the snapshot with the current branch. that might give a hint if SDK has increased in size or not.

kiryldz
kiryldz reviewed Feb 16, 2022
View reviewed changes
.gitignore Show resolved Hide resolved
kiryldz
kiryldz approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge and iterate

pengdev
pengdev approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@pengdev pengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and address the remaining issues/tickets as follow up.

@ank27 ank27 changed the title Bump gradle-version, dependencies Bump gradle-version, dependencies, support JDK 11 Feb 17, 2022
kiryldz
kiryldz reviewed Feb 17, 2022
View reviewed changes
DEVELOPING.md Outdated Show resolved Hide resolved
kiryldz
kiryldz reviewed Feb 17, 2022
View reviewed changes
DEVELOPING.md Outdated
@@ -30,10 +30,14 @@ The only requirement is to install the latest version of
[`sdkmanager`](https://developer.android.com/studio/command-line/sdkmanager) command line or
through the GUI interface to make sure the extra requirements to build Android are met.

Note: We use Android gradle plugin v7.0+ to build the project, which requires JDK 11.
when building project, make sure you have JDK 11 installed and set it as JAVA_HOME variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop this line at all and use my suggestion above.

@yunikkk
Copy link
Contributor

yunikkk commented Feb 17, 2022

Noting that with AGP7+ compose app could now be a module instead of separate project inside #695

@ank27 ank27 merged commit d44ef66 into main Feb 17, 2022
@ank27 ank27 deleted the ak-add-plugins-version branch February 17, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunikkk yunikkk yunikkk approved these changes

@kiryldz kiryldz kiryldz approved these changes

@pengdev pengdev pengdev approved these changes

@Chaoba Chaoba Chaoba approved these changes

@tarigo tarigo Awaiting requested review from tarigo

Assignees

@ank27 ank27

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ank27 @kiryldz @yunikkk @pengdev @Chaoba