Replace old render cache API with new implementation. #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoba
reviewed
Jun 8, 2021
tobrun
approved these changes
Jun 8, 2021
pengdev
force-pushed
the
peng-introduce-new-rendercache-api
branch
from
e187609
to
209d441
Compare
Chaoba
approved these changes
Jun 8, 2021
UWDIEYN-NETWORK-DIGITAL-CENTER
added a commit
to UWDIEYN-NETWORK-DIGITAL-CENTER/mapbox-maps-android
that referenced
this pull request
Jun 14, 2021
# 10.0.0-rc.1 June 14, 2021 **The Mapbox Maps SDK for Android has moved to release candidate status and is now ready for production use.** ## Breaking changes⚠️ * Rename setter for `Light` object from `add` to `set`. This matches API from GL-JS and clarifies there is only 1 Light object. ([#387](mapbox#387)) * Rename setter for `Terrain` object from `add` to `set`. ([#391](mapbox#391)) * Remove `CacheManager`. In the following releases, an API to control temporary map data may be provided. ([mapbox#399](mapbox#399)) * Remove `ResourceOptions::cacheSize` and `DefaultAmbientCacheSize` constant. ([mapbox#399](mapbox#399)) * Replace `ResourceOptions::cachePath` with `ResourceOptions::dataPath` that accepts a folder in which the map stores offline style packages and temporary map data. ([mapbox#399](mapbox#399)) * Rename `TileStore::getInstance()` to `TileStore::create()`. ([mapbox#399](mapbox#399)) * Remove the `MapView#setRenderCache` and `MapSurface#setRenderCache` API and replaced them with experimental `MapboxMap#setRenderCacheOptions` and `MapboxMap#getRenderCacheOptions` APIs. ([mapbox#401](mapbox#401)) * Change the default `ResourceOptions#dataPath` to `${context.filesDir.absolutePath}/.mapbox/map_data/` and the database name from `ambient_cache.db` to `map_data.db`. ([mapbox#403](mapbox#403))
UWDIEYN-NETWORK-DIGITAL-CENTER
added a commit
to UWDIEYN-NETWORK-DIGITAL-CENTER/mapbox-maps-android
that referenced
this pull request
Jun 14, 2021
# 10.0.0-rc.1 June 14, 2021 **The Mapbox Maps SDK for Android has moved to release candidate status and is now ready for production use.** ## Breaking changes⚠️ * Rename setter for `Light` object from `add` to `set`. This matches API from GL-JS and clarifies there is only 1 Light object. ([#387](mapbox#387)) * Rename setter for `Terrain` object from `add` to `set`. ([#391](mapbox#391)) * Remove `CacheManager`. In the following releases, an API to control temporary map data may be provided. ([mapbox#399](mapbox#399)) * Remove `ResourceOptions::cacheSize` and `DefaultAmbientCacheSize` constant. ([mapbox#399](mapbox#399)) * Replace `ResourceOptions::cachePath` with `ResourceOptions::dataPath` that accepts a folder in which the map stores offline style packages and temporary map data. ([mapbox#399](mapbox#399)) * Rename `TileStore::getInstance()` to `TileStore::create()`. ([mapbox#399](mapbox#399)) * Remove the `MapView#setRenderCache` and `MapSurface#setRenderCache` API and replaced them with experimental `MapboxMap#setRenderCacheOptions` and `MapboxMap#getRenderCacheOptions` APIs. ([mapbox#401](mapbox#401)) * Change the default `ResourceOptions#dataPath` to `${context.filesDir.absolutePath}/.mapbox/map_data/` and the database name from `ambient_cache.db` to `map_data.db`. ([mapbox#403](mapbox#403))
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Removed theMapView#setRenderCacheandMapSurface#setRenderCacheAPI, and replaced them withMapboxMap#setRenderCacheOptionsandMapboxMap#getRenderCacheOptions.</changelog>.Summary of changes
This PR removes the
MapView#setRenderCacheandMapSurface#setRenderCacheAPI, and replaced them withMapboxMap#setRenderCacheOptionsandMapboxMap#getRenderCacheOptions.User impact (optional)