Fix HistoryEventMapper#mapNavigationRoute
for when SetRouteHistoryRecord
has empty routeRequest
#5614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
HistoryEventMapper#mapNavigationRoute
for whenSetRouteHistoryRecord
has emptyrouteRequest
(old history files may include empty).Found it when trying to replay 2021-12-13T19_28_13_2021-12-13T20_11_45_active_guidance_9c145c6e-cb71-4bf2-9895-1b0ee96a1d78.pbf.gz that was causing the following crash:
Which will be fix when mapbox/mapbox-java#1386 lands and gets integrated into the SDK.
I've tested with Mapbox Java
v6.5.0-PGS-SNAPSHOT
. Noting that a Mapbox Java release is not blocking this PR but it is needed to support replaying old history files.