Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HistoryEventMapper#mapNavigationRoute for when SetRouteHistoryRecord has empty routeRequest #5614

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fix HistoryEventMapper#mapNavigationRoute for when SetRouteHistoryRecord has empty routeRequest #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Mapbox welcomes participation and contributions from everyone.
#### Features

#### Bug fixes and improvements
- Fixed `HistoryEventMapper#mapNavigationRoute` for when `SetRouteHistoryRecord` has empty `routeRequest`. [#5614](https://github.com/mapbox/mapbox-navigation-android/pull/5614)

## Mapbox Navigation SDK 2.4.0-beta.3 - March 25, 2022
### Changelog
Expand Down
2 changes: 2 additions & 0 deletions ...igation-core/src/main/java/com/mapbox/navigation/core/history/model/HistoryEventMapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ internal class HistoryEventMapper {
try {
val directionsResponse = DirectionsResponse.fromJson(response)
val routeOptions = setRoute.routeRequest?.let {
// Old records may include empty routeRequest
if (it.isEmpty()) return@let null
RouteOptions.fromUrl(URL(it))
} ?: directionsResponse.routes().firstOrNull()?.routeOptions()
?: throw noOptionsException
Expand Down