optimizes road objects creation by re-using the parsing that was already done #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
added
needs backporting
Merged
dzinad
approved these changes
Sep 23, 2022
LukasPaczos
force-pushed
the
lp-optimize-road-objects-parsing
branch
from
4341362
to
38c2857
Compare
Codecov Report
@@ Coverage Diff @@
## main #6375 +/- ##
=========================================
Coverage 68.89% 68.89%
Complexity 4552 4552
=========================================
Files 686 686
Lines 27211 27209 -2
Branches 3179 3179
=========================================
- Hits 18747 18746 -1
Misses 7240 7240
+ Partials 1224 1223 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skips the manual parsing work and re-uses the results that were already done during route generation.