Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #6375 #6378 #6376

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Backport #6375 #6378 #6376

merged 2 commits into from
Sep 23, 2022

Conversation

LukasPaczos
Copy link
Member

@LukasPaczos LukasPaczos commented Sep 23, 2022 •
edited
Loading

Description

Backports #6375 and #6378.

@LukasPaczos LukasPaczos added skip changelog Should not be added into version changelog. improvement Improvement for an existing feature. labels Sep 23, 2022
@LukasPaczos LukasPaczos requested a review from a team as a code owner September 23, 2022 09:37
@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #6376 (7076642) into release-v2.8 (014a0b6) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-v2.8    #6376   +/-   ##
===============================================
  Coverage           68.93%   68.94%           
  Complexity           4530     4530           
===============================================
  Files                 682      682           
  Lines               27078    27092   +14     
  Branches             3170     3171    +1     
===============================================
+ Hits                18667    18678   +11     
- Misses               7187     7191    +4     
+ Partials             1224     1223    -1
Impacted Files Coverage Δ
...avigation/base/internal/route/NavigationRouteEx.kt 80.76% <0.00%> (-1.05%) ⬇️
...vigation/core/trip/session/NativeSetRouteResult.kt 29.16% <16.66%> (-0.84%) ⬇️
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 68.80% <100.00%> (ø)
.../navigation/core/trip/session/MapboxTripSession.kt 86.99% <100.00%> (+0.64%) ⬆️

@LukasPaczos LukasPaczos changed the title Backport #6375 Backport #6375 #6378 Sep 23, 2022
@LukasPaczos
Copy link
Member Author

LukasPaczos commented Sep 23, 2022 •
edited
Loading

Updated to include #6378.

@LukasPaczos LukasPaczos force-pushed the lp-cp-6375 branch 2 times, most recently from bfc87b1 to 6d6a659 Compare September 23, 2022 16:18
@LukasPaczos LukasPaczos merged commit 2c7aed7 into release-v2.8 Sep 23, 2022
@LukasPaczos LukasPaczos deleted the lp-cp-6375 branch September 23, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzinad dzinad dzinad approved these changes

Assignees
No one assigned
Labels
improvement Improvement for an existing feature. skip changelog Should not be added into version changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasPaczos @dzinad