Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: mapping justification, curation rules #150

Closed
matentzn opened this issue Mar 25, 2022 · 1 comment
Closed

Breaking change: mapping justification, curation rules #150

matentzn opened this issue Mar 25, 2022 · 1 comment
Assignees
Milestone

Comments

@matentzn
Copy link
Collaborator

Before moving to SSSOM version 1.0. I would like to suggest one major breaking change for SSSOM. This is coming out of our growing experience how mapping sets are being used moving forward: Let's get this right this time!

Summary:

  • change match_type to mapping_justification (issue). A mapping justification is an action (or the written representation of that action) of showing a mapping to be right or reasonable. This is to:
    • get rid of the confusion match/mapping dichotomy (thanks @graybeal to an excellent discussion clarifying this)
    • solidify the core data model of SSSOM to be a mapping (subject, predicate, object) plus a justification for the mapping, which can be anything from a human curator decision to a tool match
    • Other groups have been using mapping justifications all along [New metadata element]: mapping_justification #85
  • move mapping_justification from an enum (HumanCurated) to a proper controlled vocabulary (vocab:HumanCurated) Move match_type from enum to entity format #141
    • There will be many more justifications than the few we have already covered, and it is easier to manage these in a controlled vocabulary than an enum of a datamodel.
  • Explicitly introduce the notion of curation_rule as a separate element that applies (mostly or exclusively) to Human-curated mappings. While closely related, a mapping justification would, as @AlasdairGray describes here be the application of the curation rule in a specific instance with details of the parameters that were used. See here for an example discussion on mapping rules in the area of disease and phenotypes.

I expect a lengthy discussion here so feel free to weigh in!

@matentzn matentzn added this to the 1.0.0 milestone Apr 11, 2022
matentzn added a commit that referenced this issue Apr 11, 2022
@matentzn matentzn self-assigned this Apr 11, 2022
matentzn added a commit that referenced this issue Apr 15, 2022
…154)

* Replacing `match_type` with `mapping_justification`

See also #150

* Update sssom.yaml

* Update sssom.yaml

* Update sssom.yaml
@matentzn
Copy link
Collaborator Author

Closing this as the only thing that remains to be done is #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant