Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Parallel (Processes) in Marqo #523

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Remove Parallel (Processes) in Marqo #523

merged 10 commits into from
Jun 30, 2023

Conversation

wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Jun 30, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove Parallel processes in marqo

  • What is the current behavior? (You can also link to an open issue here)
    we have a processes parameter in marqo add_or_replace_documents API that uses multiprocess to index documents.

  • What is the new behavior (if this is a feature change)?
    We decide to remove the support of the multiprocess feature and remove the support of this parameter in the API, for the following reasons:

  1. It blows out memory (it seems that loaded models are replicated for each process)

  2. The (time) overhead from starting multiple processes makes it unviable for ~30 second HTTP requests. It only makes sense for much longer running requests (which is an unusual pattern for a REST API)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    yes, this is a breaking change

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    passes

  • Related Python client changes (link commit/PR here)
    on going

  • Related documentation changes (link commit/PR here)
    parameter processes has already been removed from the doc

  • Other information:
    not

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex requested a review from farshidz June 30, 2023 01:57
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite June 30, 2023 02:01 — with GitHub Actions Inactive
src/marqo/tensor_search/api.py Outdated Show resolved Hide resolved
src/marqo/tensor_search/tensor_search.py Outdated Show resolved Hide resolved
src/marqo/tensor_search/api.py Outdated Show resolved Hide resolved
tests/tensor_search/test_parallel.py Outdated Show resolved Hide resolved
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite June 30, 2023 04:34 — with GitHub Actions Inactive
@wanliAlex wanliAlex merged commit 183ab42 into mainline Jun 30, 2023
5 of 6 checks passed
@wanliAlex wanliAlex deleted the li/remove-parallel branch June 30, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants