remove processes in py-marqo #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandu-k
approved these changes
Jun 30, 2023
| # should only refresh on the last call, if auto_refresh=True | ||
| assert all([f'refresh=false' in d[1]['path'] for d in | ||
| mock__post.call_args_list][:-1]) | ||
| if auto_refresh: |
There was a problem hiding this comment.
nit: we can add an else here too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
we remove the support for parameter
processesin add_documents.What is the current behavior? (You can also link to an open issue here)
we have a
processesparameter in add_documentsWhat is the new behavior (if this is a feature change)?
we remove it
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
yes it is.
Other information:
this PR is related to Remove Parallel (Processes) in Marqo marqo#523
the tox has passed against the corresponding marqo branch.
