Fix incorrect backup key format in SSSS #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
requested changes
Apr 9, 2020
jryans
approved these changes
Apr 9, 2020
|
Manually testing with an actual Riot, I found one bug in the bootstrap process that prevented bootstrapping when starting with only key backup, which is now fixed in this PR. I also have one scenario in which key backups don't seem to be working at all; I'm investigating whether it's due to this PR or something else. |
FTR, it appears to be element-hq/element-web#13151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes element-hq/element-web#12970
I'm planning on tidying up the unit tests a bit, but otherwise this should be ready for review.