Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if you log out too quickly after sending an e2ee message, your key doesn't get backed up #13151

Closed
uhoreg opened this issue Apr 13, 2020 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2158
Closed

if you log out too quickly after sending an e2ee message, your key doesn't get backed up #13151

uhoreg opened this issue Apr 13, 2020 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2158
Labels
A-E2EE-Cross-Signing A-Logout Logout, sign out, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist

Comments

@uhoreg
Copy link
Member

uhoreg commented Apr 13, 2020

possibly also happens on incoming sessions. _backupPendingKeys should be triggered on logout.
@uhoreg uhoreg mentioned this issue Apr 13, 2020
Merged
@jryans
Copy link
Collaborator

jryans commented Apr 14, 2020

Seems like something we should look into, but not really specific to the core of cross-signing work, so could come after release.

@kittykat
Copy link
Contributor

@jryans @uhoreg Can either of you still reproduce this? We couldn't during the community testing session, so this issue is a candidate for closing.

@uhoreg
Copy link
Member Author

uhoreg commented Dec 20, 2021

As far as I can tell from reading the code, it hasn't been fixed yet.

@SimonBrandner SimonBrandner added A-Logout Logout, sign out, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Dec 22, 2021
@uhoreg uhoreg mentioned this issue Feb 4, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Mar 5, 2022
@su-ex
Merge tag 'v15.6.0' into sc
8502dd1 
* Return send event response from MSC3089Branch.createNewVersion() ([\matrix-org#2186](matrix-org#2186)).
* Add functions to support refresh tokens ([\matrix-org#2178](matrix-org#2178)).
* [Release] Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2202](matrix-org#2202)).
* Fix bug where calls could break if rejected from somewhere else ([\matrix-org#2189](matrix-org#2189)).
* Fix camera stuck on after call transfer ([\matrix-org#2188](matrix-org#2188)).
* Fix synthetic read receipt handling ([\matrix-org#2174](matrix-org#2174)). Fixes element-hq/element-web#21016.
* Revert "Sign backup with cross-signing key when we reset it." ([\matrix-org#2175](matrix-org#2175)).
* Sign backup with cross-signing key when we reset it. ([\matrix-org#2170](matrix-org#2170)).
* Fix error in uploadContent() when file is empty under Node.js ([\matrix-org#2155](matrix-org#2155)).
* Check the backup info against the stored private key when determining trust. ([\matrix-org#2167](matrix-org#2167)).
* Back up keys before logging out ([\matrix-org#2158](matrix-org#2158)). Fixes element-hq/element-web#13151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE-Cross-Signing A-Logout Logout, sign out, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Back up keys before logging out uhoreg/matrix-js-sdk
5 participants
@kittykat @jryans @uhoreg @duxovni @SimonBrandner