Fix synthetic read receipt handling #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edge of a real receipt coming in later than a synthetic but referring to an earlier event caused read receipts to wrongly go upwards in the timeline
t3chguy
changed the title
turt2live
reviewed
Feb 14, 2022
There was a problem hiding this comment.
overall seems fine - just concerned about the dual naming of "fake" and "synthetic" read receipts - we should use a single term to describe them.
My preference is towards "synthetic" largely for historical purposes, but ultimately I don't mind if we pick "fake" instead (especially considering "synthetic" is a bit unfriendly to not-English languages)
turt2live
approved these changes
Feb 15, 2022
dbkr
pushed a commit
that referenced
this pull request
Feb 17, 2022
dbkr
added a commit
that referenced
this pull request
Feb 17, 2022
su-ex
pushed a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 27, 2022
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 5, 2022
* Return send event response from MSC3089Branch.createNewVersion() ([\matrix-org#2186](matrix-org#2186)). * Add functions to support refresh tokens ([\matrix-org#2178](matrix-org#2178)). * [Release] Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2202](matrix-org#2202)). * Fix bug where calls could break if rejected from somewhere else ([\matrix-org#2189](matrix-org#2189)). * Fix camera stuck on after call transfer ([\matrix-org#2188](matrix-org#2188)). * Fix synthetic read receipt handling ([\matrix-org#2174](matrix-org#2174)). Fixes element-hq/element-web#21016. * Revert "Sign backup with cross-signing key when we reset it." ([\matrix-org#2175](matrix-org#2175)). * Sign backup with cross-signing key when we reset it. ([\matrix-org#2170](matrix-org#2170)). * Fix error in uploadContent() when file is empty under Node.js ([\matrix-org#2155](matrix-org#2155)). * Check the backup info against the stored private key when determining trust. ([\matrix-org#2167](matrix-org#2167)). * Back up keys before logging out ([\matrix-org#2158](matrix-org#2158)). Fixes element-hq/element-web#13151.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21016
The complexity in this area of code is worth the performance gains, with more testing and comments now it should be more maintainable too.
Here's what your changelog entry will look like:
🐛 Bug Fixes