Remove groups and groups-related APIs #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is due for removal in Synapse and has been deprecated for a very long time. People should move away from it soon, but just in case we'll declare this as a breaking change. There is no impact on sync storage here: we happen to store the data in a way that is backwards-compatible for group-supporting clients, and the code guards against missing data from the stores. So, if someone were to revert, they'd be "safe" (probably lose all their group info, but the app wouldn't crash).
Codecov Report
@@ Coverage Diff @@
## develop #2234 +/- ##
===========================================
+ Coverage 58.11% 58.58% +0.47%
===========================================
Files 92 91 -1
Lines 16427 16271 -156
Branches 3782 3757 -25
===========================================
- Hits 9546 9532 -14
+ Misses 6881 6739 -142
|
turt2live
commented
Mar 11, 2022
Comment on lines
-8799
to
-8845
| // ====================================================== | ||
| // ** ANCIENT APIS BELOW ** | ||
| // ====================================================== |
There was a problem hiding this comment.
I would like to point out that code got added below this warning that is not subject to the "ancient apis" warning. Not sure if we should do a better job communicating these things in the future.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 16, 2022
* Remove groups and groups-related APIs ([\matrix-org#2234](matrix-org#2234)). * Add Element video room type ([\matrix-org#2273](matrix-org#2273)). * Live location sharing - handle redacted beacons ([\matrix-org#2269](matrix-org#2269)). * Fix getSessionsNeedingBackup() limit support ([\matrix-org#2270](matrix-org#2270)). Contributed by @adamvy. * Fix issues with /search and /context API handling for threads ([\matrix-org#2261](matrix-org#2261)). Fixes element-hq/element-web#21543. * Prevent exception 'Unable to set up secret storage' ([\matrix-org#2260](matrix-org#2260)).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with but not blocked alongside matrix-org/matrix-react-sdk#8027
Paired with matrix-org/synapse#12200 to a degree
For element-hq/element-web#17532
Must not land before matrix-org/matrix-react-sdk#8027
This API is due for removal in Synapse and has been deprecated for a very long time. People should move away from it soon, but just in case we'll declare this as a breaking change.
There is no impact on sync storage here: we happen to store the data in a way that is backwards-compatible for group-supporting clients, and the code guards against missing data from the stores. So, if someone were to revert, they'd be "safe" (probably lose all their group info, but the app wouldn't crash).
Here's what your changelog entry will look like:
🚨 BREAKING CHANGES