Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the matrix-sdk crates to 9b05d0d822 #124

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update the matrix-sdk crates to 9b05d0d822 #124

merged 1 commit into from
Jun 13, 2024

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jun 13, 2024

No description provided.

@poljar poljar requested a review from a team as a code owner June 13, 2024 14:06
@poljar poljar requested a review from richvdh June 13, 2024 14:06
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Hywan Hywan merged commit b6a1de7 into main Jun 13, 2024
3 checks passed
@Hywan Hywan deleted the poljar/bump-sdk branch June 13, 2024 14:36
Comment on lines +7 to +9
- `Device.requestVerification`, `UserIdentities.requestVerification`, and
`UserIdentities.verificationRequestContent` is not async anymore.
([#3513](https://github.com/matrix-org/matrix-rust-sdk/pull/3513))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth mentioning that converting an async function to not-async is not normally a breaking change in JS (though typescript might complain at you about the redundant await).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's unexpected, thanks for letting me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth mentioning that converting an async function to not-async is not normally a breaking change in JS (though typescript might complain at you about the redundant await).

I disagree, as the method return value loses .then and .catch properties for non-async-await envs.

Comment on lines +11 to +12
- Use the server name in the `QrCodeData` instead of the homeserver URL.
([#3537](https://github.com/matrix-org/matrix-rust-sdk/pull/3537))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a breaking change either?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we did rename the field, and the type of the field, thus the getter in the bindings was also renamed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it might be good to call out that rename then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants