-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the matrix-sdk crates to 9b05d0d822 #124
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,16 @@ | ||
# UNRELEASED | ||
|
||
**BREAKING CHANGES** | ||
|
||
- Update matrix-rust-sdk to `9b05d0d82`, which includes: | ||
|
||
- `Device.requestVerification`, `UserIdentities.requestVerification`, and | ||
`UserIdentities.verificationRequestContent` is not async anymore. | ||
([#3513](https://github.com/matrix-org/matrix-rust-sdk/pull/3513)) | ||
|
||
- Use the server name in the `QrCodeData` instead of the homeserver URL. | ||
([#3537](https://github.com/matrix-org/matrix-rust-sdk/pull/3537)) | ||
Comment on lines
+11
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is a breaking change either? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well we did rename the field, and the type of the field, thus the getter in the bindings was also renamed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah, it might be good to call out that rename then? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
# matrix-sdk-crypto-wasm v5.0.0 | ||
|
||
**BREAKING CHANGES** | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning that converting an async function to not-async is not normally a breaking change in JS (though typescript might complain at you about the redundant
await
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's unexpected, thanks for letting me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree, as the method return value loses
.then
and.catch
properties for non-async-await envs.