Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Revert "Stop returning an unused column when handling new receipts. (#…
Browse files Browse the repository at this point in the history
…13933)"

This reverts commit 7766bd5.
  • Loading branch information
clokep authored Sep 28, 2022
1 parent 7766bd5 commit 462428b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion changelog.d/13933.feature

This file was deleted.

4 changes: 2 additions & 2 deletions synapse/storage/databases/main/event_push_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ def _handle_new_receipts_for_notifs_txn(self, txn: LoggingTransaction) -> bool:
)

sql = """
SELECT r.room_id, r.user_id, e.stream_ordering
SELECT r.stream_id, r.room_id, r.user_id, e.stream_ordering
FROM receipts_linearized AS r
INNER JOIN events AS e USING (event_id)
WHERE ? < r.stream_id AND r.stream_id <= ? AND user_id LIKE ?
Expand All @@ -1078,7 +1078,7 @@ def _handle_new_receipts_for_notifs_txn(self, txn: LoggingTransaction) -> bool:

# For each new read receipt we delete push actions from before it and
# recalculate the summary.
for room_id, user_id, stream_ordering in rows:
for _, room_id, user_id, stream_ordering in rows:
# Only handle our own read receipts.
if not self.hs.is_mine_id(user_id):
continue
Expand Down

0 comments on commit 462428b

Please sign in to comment.