Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Avoid returning an unused column. #13933

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Avoid returning an unused column. #13933

merged 2 commits into from
Sep 28, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Sep 28, 2022

I don't think there's any benefit to returning this column (maybe an old version of Postgres/SQLite made you return it if you ordered by it or something, but I'd be surprised by that?)

Let's get some CI going...

@clokep clokep marked this pull request as ready for review September 28, 2022 14:09
@clokep clokep requested a review from a team as a code owner September 28, 2022 14:09
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy!

@clokep clokep merged commit 7766bd5 into develop Sep 28, 2022
@clokep clokep deleted the clokep/unused-stream-id branch September 28, 2022 14:58
clokep added a commit that referenced this pull request Sep 28, 2022
clokep added a commit that referenced this pull request Sep 28, 2022
…13933)" (#13935)

This reverts commit 7766bd5 (#13933).

The unused column is actually used, but much further down in the function.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants