Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warnings: replace bs with mel #799

Merged
merged 7 commits into from
Oct 22, 2023
Merged

warnings: replace bs with mel #799

merged 7 commits into from
Oct 22, 2023

Conversation

jchavarri
Copy link
Member

Partially tackles #747 (still not fixing the appearances of @bs in type errors that @davesnx mentioned).

Companion PR of melange-re/melange-compiler-libs#29.

@jchavarri
Copy link
Member Author

opam ci build is ok but the nix one is failing for some reason.

@anmonteiro
Copy link
Member

opam ci build is ok but the nix one is failing for some reason.

Probably just needs a nix flake update (when we change compiler libs -- and probably warrants mentioning this in CONTRIBUTING.md too -- I'll do it)

@anmonteiro
Copy link
Member

probably warrants mentioning this in CONTRIBUTING.md

Check #802

@jchavarri
Copy link
Member Author

Thanks for #802. Unfortunately my local nix installation broke for some reason. I don't have the nix exe available anymore, and the .nix-profile symlink is pointing to a file that no longer exists. I will try to fix it eventually, but in the meantime I'm unable to test the fix you recommended in that PR.

@anmonteiro
Copy link
Member

no worries. we need to get melange-re/melange-compiler-libs#29 merged before that, anyway. will work on reviewing it first.

anmonteiro and others added 2 commits October 22, 2023 01:01
@anmonteiro
Merge branch 'main' into mel-warnings
d3e8c0e
@jchavarri @anmonteiro
start separating js.t from js_internal.t (#798)
5455684 
* start separating js.t from js_internal.t

* refactor: remove .mli, move some comments around

* refactor: how we expose Js_OO

* add changelog entry

---------

Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@jchavarri jchavarri merged commit 616bbdf into main Oct 22, 2023
4 checks passed
@jchavarri jchavarri deleted the mel-warnings branch October 22, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchavarri @anmonteiro