Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(dev): Add CONTRIBUTING.md section about updating vendored submodules #802

Merged
merged 1 commit into from
Oct 21, 2023
Merged

doc(dev): Add CONTRIBUTING.md section about updating vendored submodules #802

merged 1 commit into from
Oct 21, 2023

Conversation

anmonteiro
Copy link
Member

No description provided.

@anmonteiro anmonteiro mentioned this pull request Oct 21, 2023
Merged
jchavarri
jchavarri approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@anmonteiro anmonteiro merged commit 554e85b into main Oct 21, 2023
4 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/add-contributing-doc branch October 21, 2023 21:23
jchavarri added a commit that referenced this pull request Oct 22, 2023
@jchavarri
Merge branch 'main' into split-jst-jsinternalt
d5f38ed 
* main:
  refactor: deduplicate functions in Utf8 logic (#803)
  test: remove cppo `#if false` for tests that we don't run (#804)
  doc(dev): Add CONTRIBUTING.md section about updating vendored submodules (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchavarri jchavarri jchavarri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmonteiro @jchavarri