[README] updated logo in readme #316
Conversation
Signed-off-by: nishantn31 <nishantn31@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack. |
README.md
Outdated
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><picture align="center"> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-light-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | ||
| <img alt="Shows an illustrated light mode meshery logo in light color mode and a dark mode meshery logo dark color mode." src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-tag-light-text-side.png" width="70%" align="center" style="margin-bottom:20px;"> |
There was a problem hiding this comment.
Thanks! Will you change the alt text to simply “Meshery logo”?
in order to enhance maintainability cross on the repos, are you able to copy and paste directly from the other read me?
Ultimately, we want to drop the tagline “multi-mesh manager”. We are just looking for the word “Meshery” without any tagline. Will you confirm that this is the version you are using?
There was a problem hiding this comment.
Yes I have copied the same image from meshery repo and it does not include the tagline "the multimesh manager"
There was a problem hiding this comment.
Excellent. Thank you, @nishantn31
Signed-off-by: nishantn31 <nishantn31@gmail.com>
nishantn31
force-pushed
the
logo-update
branch
from
7aa541f
to
892fcd5
Compare
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><img align="center" style="margin-bottom:20px;" src="https://raw.githubusercontent.com/layer5io/layer5/master/.github/assets/images/meshery/meshery-logo-tag-light-text-side.png" width="70%" /></a><br /><br /></p> | ||
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><picture align="center"> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-light-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> |
There was a problem hiding this comment.
Needs modification , light mode doesn't look appropriate .
There was a problem hiding this comment.
@legendarykamal It is working fine for me both on light and dark mode. Can you share more details - platform/browser etc
There was a problem hiding this comment.
ok @nishantn31 must have been a glitch from my end, rechecked looks fine ,
congrats your first PR got merged 🥳 .
|
Thanks for your contribution to the Layer5 community! 🎉
|
|
Yay! |
|
More help needed with this second Meshery logo, @nishantn31 - |
Signed-off-by: nishantn31 nishantn31@gmail.com
Description
Updated the logo in readme and made it consistent with meshery repo readme logo
This PR fixes #313
Notes for Reviewers
Signed commits