[README] updated logo in readme #316
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| <p style="text-align:center;" align="center"><a href="https://layer5.io/meshery"><picture align="center"> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-dark-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-light-text-side.svg" width="70%" align="center" style="margin-bottom:20px;"> | ||
| <img alt="Shows an illustrated light mode meshery logo in light color mode and a dark mode meshery logo dark color mode." src="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/meshery/meshery-logo-tag-light-text-side.png" width="70%" align="center" style="margin-bottom:20px;"> | ||
|
There was a problem hiding this comment. Thanks! Will you change the alt text to simply “Meshery logo”? in order to enhance maintainability cross on the repos, are you able to copy and paste directly from the other read me? Ultimately, we want to drop the tagline “multi-mesh manager”. We are just looking for the word “Meshery” without any tagline. Will you confirm that this is the version you are using? There was a problem hiding this comment. Yes I have copied the same image from meshery repo and it does not include the tagline "the multimesh manager" There was a problem hiding this comment. Excellent. Thank you, @nishantn31 |
||
| </picture></a><br /><br /></p> | ||
|
|
||
| # Meshery Adapter for Consul | ||
|
|
||
|
|
@@ -13,7 +17,6 @@ | |
| [](http://slack.layer5.io/) | ||
| [](https://bestpractices.coreinfrastructure.org/projects/3564) | ||
|
|
||
| <p style="clear:both;"> | ||
| <h2><a href="https://layer5.io/meshery">Meshery</a></h2> | ||
| <a href="https://meshery.io"><img src="https://raw.githubusercontent.com/meshery/meshery-consul/master/.github/img/readme/meshery-logo-light-text.svg" | ||
|
|
@@ -44,9 +47,11 @@ Our projects are community-built and welcome collaboration. 👍 Be sure to see | |
| ## About Layer5 | ||
|
|
||
| **Community First** | ||
|
|
||
| <p>The <a href="https://layer5.io">Layer5</a> community represents the largest collection of service mesh projects and their maintainers in the world.</p> | ||
|
|
||
| **Open Source First** | ||
|
|
||
| <p>We build projects to provide learning environments, deployment and operational best practices, performance benchmarks, create documentation, share networking opportunities, and more. Our shared commitment to the open source spirit pushes Layer5 projects forward.</p> | ||
|
|
||
| **License** | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs modification , light mode doesn't look appropriate .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legendarykamal It is working fine for me both on light and dark mode. Can you share more details - platform/browser etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legendarykamal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok @nishantn31 must have been a glitch from my end, rechecked looks fine ,
congrats your first PR got merged 🥳 .