Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the security issues #405

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fixed the security issues #405

merged 1 commit into from
Oct 31, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Oct 31, 2023

Description

This PR fixes #307 #397

Notes for Reviewers

Bumping version

  • Go v1.21
  • github.com/layer5io/meshery-adapter-library v1.1.0
  • github.com/layer5io/meshkit v0.6.78

Fixing security issues

This PR also fixed the security issues. These issues have been in here for a long time.

Breaking change

This PR also includes the breaking change. According to meshery/meshery#7434 and meshery/meshery-linkerd#519. The OAM registration should be removed.

So, here we remove all of them

Release version

In order to help to test the compatibility of the adapter. We will release a specific version of the adapter. This will help us split the specific version to the current stable version.

Signed commits

  • Yes, I signed my commits.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba626a) 0.00% compared to head (8c18267) 0.00%.

❗ Current head 8c18267 differs from pull request most recent head ee6564a. Consider uploading reports for the commit ee6564a to get more accurate results

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #405   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aisuko Aisuko self-assigned this Oct 31, 2023
@Aisuko Aisuko added area/ci Continuous Integration language/go Golang related labels Oct 31, 2023
@Aisuko Aisuko force-pushed the fix/security-issue branch 2 times, most recently from 5d569ad to b95ae0a Compare October 31, 2023 02:42
Signed-off-by: GitHub <noreply@github.com>
@Aisuko Aisuko merged commit d2f1b16 into master Oct 31, 2023
7 of 11 checks passed
@Aisuko Aisuko deleted the fix/security-issue branch October 31, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Update OpenTelemetry (dependent on meshery-adapter-library)
1 participant