Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix failing E2E tests #519

Merged
merged 11 commits into from
Jun 22, 2023
Merged

[CI] Fix failing E2E tests #519

merged 11 commits into from
Jun 22, 2023

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Jun 22, 2023 •
edited
Loading

Description

This PR fixes/updates following:

  1. Failing E2E tests due to missing MeshModel components from latest release of Linkerd
  2. Add missing Linkerd service mesh and addons MeshModel components
  3. Removes all the old unused OAM components and code
  4. Updates go.mod with latest Meshery Adapter Library and Meshkit
  5. Updated .golanci.yaml with the one in Meshery Istio Adapter

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@theBeginner86
rm unused code
7cd3a4c 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
update dynamic reg; remove commented out code
805cc6b 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
fix missing code models; gen new components
a43b481 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
rm all oam components
207dc9c 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
update go.mod
49c6750 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
revert missing change'
3950658 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
rm more OAM
aa95318 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
fix lint check
012f19b 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
fix lint checks
009b6ae 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
update golanci.yaml with meshery-istio adapter one
afac6bf 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

All ✅

@theBeginner86
rm comments from go.mod
5f3362b 
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@leecalcote
Copy link
Member

Whoa! All greens!

leecalcote
leecalcote approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more than good to me.

@leecalcote leecalcote merged commit 9a20167 into meshery:master Jun 22, 2023
This was referenced Oct 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

@Aisuko Aisuko Awaiting requested review from Aisuko

Assignees
No one assigned
Labels
area/ci kind/chore Necessary task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theBeginner86 @leecalcote