Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kommander: Bump kommander-karma and kommander-thanos deps #446

Merged

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Feb 19, 2020

https://jira.d2iq.com/browse/D2IQ-64099
Bumps the kommander-thanos and kommander-karma dependencies to pull in the latest changes which added the secret reloader annotations.

The following needs to be done (with #438 merge):

  1. Bump the version of mtls-proxy used in kommander-thanos and kommander-karma and add the secret.reloader.stakater.com/reload annotations ✅ DONE IN [kommander-karma] [kommander-thanos] Add secret reloader annotations #443
  2. Bump the deps of kommander-thanos and kommander-karma in kommander chart to pull in the latest changes from the above ✅ DONE IN THIS PR
  3. Bump kommander version in kubeaddons-kommander

Testing

I tested this manually by hosting mtls-proxy, kommander-thanos, kommander-karma, and kommander charts on my personal GH. I konvoy up on addons version master, then upgraded the kommander chart by deploying addons with my kubeaddons-kommander branch gracedo/bug_certs_D2IQ-64099.

  - configRepository: https://github.com/mesosphere/kubeaddons-kommander
    #configVersion: master
    configVersion: gracedo/bug_certs_D2IQ-64099
    addonsList:
    - name: kommander
      enabled: true

Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:
image
image

I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading
image
image

@gracedo gracedo added the ready ready label Feb 19, 2020
@gracedo gracedo requested a review from a team as a code owner February 19, 2020 19:06
@gracedo gracedo self-assigned this Feb 19, 2020
@gracedo gracedo force-pushed the gracedo/bug_thanos_certs_D2IQ-64099_3 branch from 62c110e to caddb3d Compare February 19, 2020 19:07
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@GoelDeepak GoelDeepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants