-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Kommander chart #13
Conversation
@juliangieseke @hectorj2f Can we make sure to use this updated kommander chart version for tomorrow's MWT? |
labels: | ||
kubeaddons.mesosphere.io/name: kommander | ||
annotations: | ||
catalog.kubeaddons.mesosphere.io/addon-revision: "1.0.0-10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should point to -11
?
karma: | ||
deployment: | ||
annotations: | ||
configmap.reloader.stakater.com/reload: kommander-kubeaddons-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kommander-thanos
doesn't need the same annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check out #12 as there are some more recent updates there that this conflicts with and make adjustments here accordingly
@shaneutt Looks like that PR bumped to 0.4.12 which covers the 0.4.11 bump here :) closing this out! |
https://jira.d2iq.com/browse/D2IQ-64099
Bumps the
kommander
chart to pull in the latest changes which added the secret reloader annotations for karma and thanos proxies.The following needs to be done (with #438 merge):
mtls-proxy
used inkommander-thanos
andkommander-karma
and add thesecret.reloader.stakater.com/reload
annotations ✅ DONE IN [kommander-karma] [kommander-thanos] Add secret reloader annotations charts#443kommander-thanos
andkommander-karma
inkommander
chart to pull in the latest changes from the above ✅ DONE IN kommander: Bump kommander-karma and kommander-thanos deps charts#446kubeaddons-kommander
✅ DONE IN THIS PRTesting
I tested this manually by hosting
mtls-proxy
,kommander-thanos
,kommander-karma
, andkommander charts
on my personal GH. Ikonvoy up
on addons versionmaster
, then upgraded the kommander chart by deploying addons with mykubeaddons-kommander
branchgracedo/bug_certs_D2IQ-64099
(this branch has obviously now been updated to mesosphere's hosted kommander chart).Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:
I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading