Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kommander chart #13

Closed
wants to merge 2 commits into from
Closed

Bump Kommander chart #13

wants to merge 2 commits into from

Conversation

gracedo
Copy link
Collaborator

@gracedo gracedo commented Feb 19, 2020

https://jira.d2iq.com/browse/D2IQ-64099
Bumps the kommander chart to pull in the latest changes which added the secret reloader annotations for karma and thanos proxies.

The following needs to be done (with #438 merge):

  1. Bump the version of mtls-proxy used in kommander-thanos and kommander-karma and add the secret.reloader.stakater.com/reload annotations ✅ DONE IN [kommander-karma] [kommander-thanos] Add secret reloader annotations charts#443
  2. Bump the deps of kommander-thanos and kommander-karma in kommander chart to pull in the latest changes from the above ✅ DONE IN kommander: Bump kommander-karma and kommander-thanos deps charts#446
  3. Bump kommander version in kubeaddons-kommanderDONE IN THIS PR

Testing

I tested this manually by hosting mtls-proxy, kommander-thanos, kommander-karma, and kommander charts on my personal GH. I konvoy up on addons version master, then upgraded the kommander chart by deploying addons with my kubeaddons-kommander branch gracedo/bug_certs_D2IQ-64099 (this branch has obviously now been updated to mesosphere's hosted kommander chart).

  - configRepository: https://github.com/mesosphere/kubeaddons-kommander
    #configVersion: master
    configVersion: gracedo/bug_certs_D2IQ-64099
    addonsList:
    - name: kommander
      enabled: true

Upon upgrading, I verified that updated secrets were federated out to the managed clusters (as they were before) then checked that the proxies now had the reloader annotation:
image
image

I checked Thanos and Karma UIs in the kommander cluster and saw that they were still able to connect to the proxies even after upgrading
image
image

@gracedo gracedo added the ready label Feb 19, 2020
@gracedo gracedo requested a review from a team as a code owner February 19, 2020 21:21
@gracedo gracedo self-assigned this Feb 19, 2020
@gracedo
Copy link
Collaborator Author

gracedo commented Feb 19, 2020

@juliangieseke @hectorj2f Can we make sure to use this updated kommander chart version for tomorrow's MWT?

labels:
kubeaddons.mesosphere.io/name: kommander
annotations:
catalog.kubeaddons.mesosphere.io/addon-revision: "1.0.0-10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should point to -11?

karma:
deployment:
annotations:
configmap.reloader.stakater.com/reload: kommander-kubeaddons-config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kommander-thanos doesn't need the same annotation?

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check out #12 as there are some more recent updates there that this conflicts with and make adjustments here accordingly

@gracedo gracedo added blocked and removed ready labels Feb 19, 2020
@gracedo
Copy link
Collaborator Author

gracedo commented Feb 19, 2020

@shaneutt Looks like that PR bumped to 0.4.12 which covers the 0.4.11 bump here :) closing this out!

@gracedo gracedo closed this Feb 19, 2020
@shaneutt shaneutt deleted the gracedo/bug_certs_D2IQ-64099 branch February 19, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants