Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): Omit ai-nav helmrepos from bundle #2135

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Apr 16, 2024

What problem does this PR solve?:
Separate ai-nav helmrepos to separate file so we can exclude it from the bundle. I am depending on this kcli bug https://jira.nutanix.com/browse/D2IQ-97040 to continue to exist to ensure that the kustomize won't fail (kustomization.yaml specifies ai-nav file which is removed)

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off backport-pr This is a backport PR auto-backport backport-to-main labels Apr 16, 2024
@gracedo gracedo self-assigned this Apr 16, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@gracedo gracedo marked this pull request as ready for review April 16, 2024 21:08
@gracedo gracedo requested a review from msdolbey April 16, 2024 21:08
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
very clever

@gracedo gracedo merged commit 9c8ad58 into release-2.7 Apr 16, 2024
32 of 33 checks passed
@gracedo gracedo deleted the gracedo/release-2.7/xc_ainav_helmrepos branch April 16, 2024 21:26
Copy link
Contributor

💔 All backports failed

Status Branch Result
main Could not create pull request: GitHub Actions is not permitted to create or approve pull requests.

Manual backport

To create the backport manually run:

backport --pr 2135

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle

(cherry picked from commit 9c8ad58)
gracedo added a commit that referenced this pull request Apr 16, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle
gracedo added a commit that referenced this pull request Apr 17, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle
gracedo added a commit that referenced this pull request Apr 17, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle
gracedo added a commit that referenced this pull request Apr 19, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file

* fix(release): Omit ai-nav helmrepos from bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-pr This is a backport PR backport-to-main ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants