-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): Omit ai-nav helmrepos from bundle #2135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracedo
added
ready-for-review
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
backport-pr
This is a backport PR
auto-backport
backport-to-main
labels
Apr 16, 2024
github-actions
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Apr 16, 2024
kaiwalyajoshi
approved these changes
Apr 16, 2024
msdolbey
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file * fix(release): Omit ai-nav helmrepos from bundle (cherry picked from commit 9c8ad58)
gracedo
added a commit
that referenced
this pull request
Apr 16, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file * fix(release): Omit ai-nav helmrepos from bundle
2 tasks
gracedo
added a commit
that referenced
this pull request
Apr 17, 2024
* refactor(helmrepos): Separate ai-navigator helmrepos into separate file * fix(release): Omit ai-nav helmrepos from bundle
2 tasks
gracedo
added a commit
that referenced
this pull request
Apr 17, 2024
gracedo
added a commit
that referenced
this pull request
Apr 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
backport-pr
This is a backport PR
backport-to-main
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
ready-for-review
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Separate ai-nav helmrepos to separate file so we can exclude it from the bundle. I am depending on this kcli bug https://jira.nutanix.com/browse/D2IQ-97040 to continue to exist to ensure that the
kustomize
won't fail (kustomization.yaml specifies ai-nav file which is removed)Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist